wip(frankenphp.c): attempt to attach cli thread to existing TSRM#2343
Closed
wip(frankenphp.c): attempt to attach cli thread to existing TSRM#2343
Conversation
Such design enforce a call to `frankenphp.Init` prior to `frankenphp.EvalScript` . Probably not the best idea. Inspired by the current workers / threads design.
Contributor
|
When you're starting to work on this again, please reopen the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #2342
Such a design enforces a call to
frankenphp.Initprior tofrankenphp.EvalScript.Probably not the best idea.
Inspired by the current workers / threads design.